search

humanoid-path-planner / hpp-corbaserver

Corba server for Humanoid Path Planner applications
BSD 2-Clause "Simplified" License
4 stars 20 forks source link

test: fix path serialization test #205

Closed jmirabel closed 1 year ago

jmirabel commented 1 year ago

The test implemented in #197 was not working and not even launched.

nim65s commented 1 year ago

Could you make this test run in serial, in the CMakeLists.txt ?

jmirabel commented 1 year ago

Isn't it already the case ?

nim65s commented 1 year ago

I don't think so: https://github.com/humanoid-path-planner/hpp-corbaserver/blob/devel/tests/CMakeLists.txt

jmirabel commented 1 year ago

It's not

add_python_unit_test(py-path-serialization tests/path_serialization.py src)

? It is ran when I run make test.

nim65s commented 1 year ago

Sorry, I wasn't clear.

This test is starting a hppcorbaserver process. If you have a CTEST_PARALLEL_LEVEL=X with X>1 in your environment, and multiple unit-tests are trying to start hppcorbaserver processes at the same time, we get TRANSIENT errors (as seen on gitlab-ci). So we need to tell CTest that this test in particular should be run in serial, even if the user wants parallel execution.

I'm suggesting to add:

set_tests_properties("py-path-serialization" PROPERTIES RUN_SERIAL "ON")

This should make gitlab-ci happy

jmirabel commented 1 year ago

I updated as suggested. Let's see if CI goes green.