search

humanoid-path-planner / hpp-doc

Documentation for project Humanoid Path Planner
https://humanoid-path-planner.github.io/hpp-doc
ISC License
29 stars 23 forks source link

Fix version of hpp-fcl. #41

Closed jmirabel closed 5 years ago

jmirabel commented 5 years ago

This should fix #39.

florent-lamiraux commented 5 years ago

Why not using branch master ?

jmirabel commented 5 years ago

The stable Makefile uses tags 4.3.0. Using tag for the stable branch is safer that using a branch.

Now the question becomes: why hpp-fcl has a different version number ? Because there is pinocchio after hpp-fcl. hpp-fcl may have a different release frequency that HPP.

nim65s commented 5 years ago

I see 2 solutions:

  1. let hpp-fcl follow usual hpp version numbers
  2. change this to a tag: https://github.com/humanoid-path-planner/hpp-doc/blob/b1026cc5a4dac5d2b18e34c2808de4b6c75b33b1/doc/Makefile#L63
jmirabel commented 5 years ago

change this to a string:

that's what this PR does.

florent-lamiraux commented 5 years ago

Okay, understood.