search

humanoid-path-planner / hpp-pinocchio

Wrapping of Pinocchio library into HPP
BSD 2-Clause "Simplified" License
8 stars 15 forks source link

loadModel: hardcoded "urdf" & "srdf" paths #134

Closed nim65s closed 4 years ago

nim65s commented 4 years ago

Hi,

Some robots in https://github.com/gepetto/example-robot-data have their urdf data in a robots directory instead of a urdf one.

According to https://gitlab.laas.fr/stack-of-tasks/talos-data/-/issues/2#note_9710, this should not be a big issue, as "HPP can now read any directory". But if I look at https://github.com/humanoid-path-planner/hpp-pinocchio/blob/8d9e202f0d004928bbdee290475d23ba61123376/src/urdf/util.cc#L299 I can still see some hardcoded "urdf" around.

Shouldn't we add a urdfSubdir="urdf" argument to those functions ?

jmirabel commented 4 years ago

You can call loadModel directly.

nim65s commented 4 years ago

Ok, thanks :)