search

humanoid-path-planner / hpp-rbprm

"Implementation of RB-PRM planner using hpp."
5 stars 7 forks source link

% 0 in time-constraint-shooter.cc #60

Closed pFernbach closed 4 years ago

pFernbach commented 4 years ago

https://github.com/humanoid-path-planner/hpp-rbprm/blob/b8a91eaeb538d16fe1f88ef87cc54e689e626209/src/interpolation/time-constraint-shooter.cc#L91

On some occasion limb->sampleContainer_.samples_.size() == 1 which lead to a floating point error at this line. I fixed this by adding a test before the modulus, but I'm not really sure if this is supposed to happen or if there is something else that need to be fixed on the code calling this method (from limb-rrt).

pFernbach commented 4 years ago

So, the error comes from the way I used it in python. Obviously when the size is 1 the limb-rrt never converge. But, we should send a clear error message instead of leaving this obscur 'floating point exception" .