Closed leetdev closed 2 years ago
@leetdev
@Dzeranov,
@leetdev ,
No, I mean to this repo. As you can see we have a folder polygon_contracts
in this repo. So we need a similar one for bsc.
@Dzeranov I'm not sure what needs to go into that folder. Polygon I believe has its own underlying token contract for the Multichain bridge, but I saw no need to create one for BSC. The only contracts I deployed there were the Escrow Factory and the KV Store.
@leetdev
If we have a contract (in any chain) which source code is different from the one you can see in contracts
folder, it should be represented in this repo for at least two reasons:
@Dzeranov The HMT contract on BSC was deployed by Multichain as part of the bridge setup. Should I look for the source code for that and add it here?
@leetdev Yes please.
@Dzeranov I've added the token contract source code that was deployed by Multichain (verifiable at https://bscscan.com/address/0x0d501B743F22b641B8C8dfe00F1AAb881D57DDC7#code).
Hi @leetdev! Thank you for your work! We noticed that the contract is not upgradable, could you also do a proxy implementation, as is done for the polygon_contracts?
@eugenvoronov, I'm not sure what exactly you want me to do. I explained, that the polygon bridge was set up in a different way - Multichain supports both bridging to an existing token (as is the case with Polygon) as well as creating a bridge without an underlying token contract. I was not in charge of setting up the bridge, all I did was suggest using Multichain. There are other HMT bridges that have been set up using the latter model, and I don't see any proxy contracts for those. Am I missing something?
@leetdev i need to discuss this change with you can you reach out over discord?
Add support for BSC as per #335:
humanprotocol/bsc
subgraph needs to be created on thegraph hosted service)Additionally, improved the truffle
deploy_contracts
migration script to include deployment of the EscrowFactory contract.