humanswitch / consentcookie

Open source AVG solution for websites
Apache License 2.0
27 stars 10 forks source link

Fix missing info link for the applications #58

Closed StevenChoo closed 6 years ago

StevenChoo commented 6 years ago

Description

The link below in the applications screen got removed for some reason but should not have been.

image

Expected Behavior

Link shown in screenshot above should show

Actual Behavior

Link isn`t shown

Possible Fix

Add the link

StevenChoo commented 6 years ago

Fixed missing link in applications view.

The text of the link and the link itself can be configured by the resources. If no link is configured for the language that is selected and the default language is not nl (the default implemented in the app) no link is shown. This is because the link can be language dependant.

rockxwre commented 6 years ago

Test results :heavy_check_mark:

Link not configured for specific language :heavy_check_mark:

For the language 'English' I did not configured the moreInfo and moreInfoLink and as expected, no link was shown below the application list.

Link configured for specific language :heavy_check_mark:

I added the following configuration to my init script:

    'general': {
      'language': {
        'default': 'en'
      },
      'resources': {
        'en': {
          'applications' : {
            'moreInfo': 'More information about this application',
            'moreInfoLink': 'https://www.consentcookie.nl?lang=en',
        }...,

and as expected, the link More information about this application was shown when I listed the applications.