search

humante / redis-browser

Web-based Redis browser that can work as standalone app or mounted Rails engine
MIT License
603 stars 67 forks source link

Require at least Ruby 1.9.2 #13

Closed ryanmjacobs closed 9 years ago

ryanmjacobs commented 9 years ago

Fixes https://github.com/monterail/redis-browser/issues/8.

Ruby 1.8 doesn't support {key: "value"} notation. It only supports {:key => "value"} notation.

See http://stackoverflow.com/a/8014115.

ghost commented 9 years ago

Ruby 1.8.7 and 1.9.2 are both EOL as of July 2014 [1].

:-1: for any change solely to support these versions of ruby, unless it's in a branch that explicitly exists for legacy compatibility.

On a related note, 1.9.3 is also deprecated and will be EOL at the end of February 2015 [2].

  1. https://www.ruby-lang.org/en/news/2014/07/01/eol-for-1-8-7-and-1-9-2/
  2. https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/

The correct solution to #8 is to bump the minimum required ruby version to something > 1.9.3.

ryanmjacobs commented 9 years ago

@BM5k Should be fixed :grinning:

ghost commented 9 years ago

:clap: This is a much better approach. My personal opinion is that 1.9.2 may be too old, too. I guess the maintainer(s) will have to make that call.

teamon commented 9 years ago

Thank a lot, I'm all for not supporting ruby 1.8.

@ryanmjacobs Could you rebase this branch and remove the first commit and it's revert?

ryanmjacobs commented 9 years ago

Squashed. :grin:

teamon commented 9 years ago

Thanks a lot!