search

humawork / compose-charts

Jetpack Compose charts for Android
Apache License 2.0
77 stars 6 forks source link

Line charts #6

Closed jaranflaath closed 3 years ago

jaranflaath commented 3 years ago

First attempt at introducing line charts. Creating this draft PR for taking input and feedback.

jaranflaath commented 3 years ago

Great work 👏

A couple of points to consider:

* Please run `./gradlew ktlintFormat` and format accordingly

* Would be nice to add optional or customisable `Legend` like in `Pie` or `Bars`

Will look into that! 👍

jaranflaath commented 3 years ago

Great work 👏 🎉

Thanks! Lots of improvements we can do still, but the basics should be here now. I submitted a small update, after you approved, to allow for different axis label colors. Please have a quick look.

Let me know if there's anything more I need to do before this can be merged and a new release published.

steelahhh commented 3 years ago

Looks good, just needs a ktlintFormat run 👍

jaranflaath commented 3 years ago

Looks good, just needs a ktlintFormat run 👍

Keep forgetting that. Done now 👍