humbi83 / lz4

Automatically exported from code.google.com/p/lz4
0 stars 0 forks source link

Naming of shared libraries on OS X #122

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
LZ4 shared libraries follow the naming scheme typical for Linux: 
`liblz4.so.1.2.3`.

When linked on OS X the naming should be different: `liblz4.1.2.3.dylib`.

Reference: 
https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/
DynamicLibraries/100-Articles/DynamicLibraryDesignGuidelines.html, section 
"Specifying Version Information".

Original issue reported on code.google.com by jasiec...@gmail.com on 14 Mar 2014 at 6:51

GoogleCodeExporter commented 8 years ago
Thanks for reference, that's clear.

Original comment by yann.col...@gmail.com on 17 Mar 2014 at 12:54

GoogleCodeExporter commented 8 years ago
Integrated into r115

Original comment by yann.col...@gmail.com on 20 Mar 2014 at 1:36

GoogleCodeExporter commented 8 years ago
Btw, I've merged this issue into r115, 
but as a quick comment
it looks like your patch produces library names like liblz4.dylib.1.2.3 for OSX
rather than liblz4.1.2.3.dylib, as suggested in your initial issue report.

Original comment by yann.col...@gmail.com on 20 Mar 2014 at 2:05

GoogleCodeExporter commented 8 years ago
Yes, that's right; the patch I attached to 115 was supposed to address the 
-Wl,-soname problem only. Thanks for taking time to go through it, though!

Original comment by jasiec...@gmail.com on 20 Mar 2014 at 2:08