humblerookie / dimenify

An android studio plugin for creating scaled dimension values for different pixel buckets
25 stars 6 forks source link

not working as expected using Android studio 3.0.1 #10

Closed FaisalJamil closed 6 years ago

FaisalJamil commented 6 years ago

Using Android Studio 3.0.1 and following these steps,
Generate for a specific dimen Locate the dimens.xml file in the editor. Move the cursor to the dimension and right click. Select Generate -> Generate alternate dimens.. Insert the scale factors you want to use for conversion and click OK. (Do not appear and hence no dimensions are generated)

Generate for an entire file Locate the dimens.xml file in the project view and right click. Select 'Generate alternate dimens from file'. Insert the scale factors for conversion and click OK. (Scale factor appear this time, but empty dimens files are generated in respective resolution folders)

humblerookie commented 6 years ago

Sorry about the delayed response. Thanks for pointing this out, will take a look today and let you know.

humblerookie commented 6 years ago

@FaisalJamil Is there any error log /trace showing up (bottom right corner on AS) while generating it? Could be a canary issue, I'm testing this on 3.1 Beta 1 and it works. Could you try it on the same?

FaisalJamil commented 6 years ago

Yeah, may be a Canary issue, as I am using it in my app. I’ll try and let you know. Thanks

On Feb 17, 2018, at 10:01 PM, Anvith Bhat notifications@github.com<mailto:notifications@github.com> wrote:

@FaisalJamilhttps://github.com/faisaljamil Is there any error log /trace showing up (bottom right corner on AS) while generating it? Could be a canary issue, I'm testing this on 3.1 Beta 1 and it works. Could you try it on the same?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/humblerookie/dimenify/issues/10#issuecomment-366471090, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE2c4k-CEf5rO5pTIguIYawdJoYtCABSks5tVz4mgaJpZM4R20tC.

humblerookie commented 6 years ago

Could you confirm if you're still facing the issue on beta?

humblerookie commented 6 years ago

I'm closing this issue on the premise that this would be a canary issue, feel free to reopen in case otherwise.