search

humbletim / glm-js

JavaScript adaptation of the OpenGL Mathematics (GLM) C++ library interfaces. JavaScript adaptation of the OpenGL Mathematics (GLM) C++ library interfaces. (project currently inactive)
http://humbletim.github.io/glm-js/
Other
43 stars 5 forks source link

if(!F[T]): Isn't this test too simple? #11

Closed cheako closed 9 months ago

cheako commented 6 years ago

https://github.com/humbletim/glm-js/blob/aef4fd1b8a330c91b71565df7b3111f1b5968544/src/glm.common.js#L557

Shouldn't this be something like if(T in F)?

humbletim commented 9 months ago

Thank you for the suggestion regarding if (T in F) (2018). While the project is now sunsetting (see #19), I appreciate you bringing it up! Best regards, -Tim