humbletim / setup-vulkan-sdk

github action that provisions the Vulkan SDK and configures VULKAN_SDK environment variable
MIT License
48 stars 12 forks source link

Support for installing glslang #6

Closed jamestmartin closed 2 years ago

jamestmartin commented 3 years ago

I use the GLSL-to-SPIR-V compiler glslangValidator from KhronosGroup/glslang as part of my build process. I would greatly appreciate it if you'd consider adding an option to install it with this action.

styler00dollar commented 2 years ago

Any update?

humbletim commented 2 years ago

As of v1.2.0-beta this action now supports building and installing glslangValidator as well:

 -name: Prepare Vulkan SDK
   uses: humbletim/setup-vulkan-sdk@v1.2.0-beta
   with:
     vulkan-query-version: 1.3.204.0
     vulkan-components: Vulkan-Headers, Vulkan-Loader, Glslang
     vulkan-use-cache: true

This action is mainly meant for compiling Vulkan SDK components from corresponding source code and with caching enabled it seems reasonable enough to include glslangValidator that way.

However, for projects that depend on multiple binary tools from the full Vulkan SDK, it may make more sense to just perform unattended installation of the official Vulkan SDK prebuilt release. In case useful to others I've put together a new action which automates that whole process for linux/mac/windows here: actions/install-vulkan-sdk.

humbletim commented 2 years ago

v1.2.0 action released with glslang support; thanks for the feedback. :)