search

humbug / phar-updater

A thing to make PHAR self-updates easy and secure
BSD 3-Clause "New" or "Revised" License
368 stars 27 forks source link

Update README.md #17

Closed glensc closed 7 years ago

glensc commented 8 years ago

use echo for messages; exit for exit code. also cosmetics to terminate messages with newline.

exit(NUMBER); is good for checking from (shell) scripts that the previous command failed.

aik099 commented 8 years ago

I see build is failing, but not due your changes. Could you please submit another PR with travis ci config changes to enable openssl extension for PHP 5.3.3?

glensc commented 8 years ago

or put 5.3.3 to allow failures?

aik099 commented 8 years ago

or put 5.3.3 to allow failures?

Of course not, because all previous PHP 5.3.3 builds have passed. Probably Travis CI issue with missing extension, but if we can fix it ourselves, then it would be good too.

glensc commented 8 years ago

i updated only README.md, having this PR blocked due travis issues is silly.

aik099 commented 8 years ago

I'm not saying that PR can't be merged due travis build fail due unrelated reason 😄

I'm just suggesting to send PR (if you can) fixing travis build.

glensc commented 7 years ago

i came across again to this repository and wanted to submit the exact same PR. ugly!

theofidry commented 7 years ago

Thanks @glensc