search

humbug / phar-updater

A thing to make PHAR self-updates easy and secure
BSD 3-Clause "New" or "Revised" License
368 stars 27 forks source link

Create .styleci.yml #24

Closed padraic closed 7 years ago

padraic commented 7 years ago

Add PSR-2 screening.

theofidry commented 7 years ago

@humbug/core wdyt of waiting for two approvals before merging and when the two are given anyone can merge?

padraic commented 7 years ago

@theofidry That sounds good here - I was going to bring up on a issue thread with a few other items, but let's see what the other guys think.

pamil commented 7 years ago

Sounds good! The only edge case happens when a core member opens a PR, shall we treat it as implicit approval or require two other core members to approve it?

theofidry commented 7 years ago

@pamil as a rule I would say no exception (for that case). However I'm also for being a minimal flexible: if the PR is relatively simple (e.g. merge a StyleCI fix) I would be ok with only one approval

padraic commented 7 years ago

I agree on keeping exceptions to simple cases - it may extend the time to getting stuff merged, but it also adds an additional layer of checking, and keeps everyone informed about what's going into the code ;).