humbug / phar-updater

A thing to make PHAR self-updates easy and secure

BSD 3-Clause "New" or "Revised" License

368 stars 27 forks source link

Update tests for PHPUnit 6 #30

Closed padraic closed 7 years ago

padraic commented 7 years ago

26 will need to be rebased if this is merged as it contains one extra testcase file.

padraic commented 7 years ago

PHP 5.4 is obviously a bridge too far on this one requiring PHPUnit 4 which can't support the PHPUnit 6 changes. Annotations for the exceptions expected may be the better route.

padraic commented 7 years ago

Will fail as expected for PHP 5.3.3 to be removed per #28

padraic commented 7 years ago

Talk about knocking the rust off something. Three PHPUnit versions, and six PHP versions later..

omissis commented 7 years ago

Ah, I haven't noticed this PR before submitting mine (https://github.com/humbug/phar-updater/pull/32). I've dropped 4.x, bumped 5.x to 5.5(as it's the oldest that seem to be supporting the FC layer, although a post on phpunit.de says it's 5.7) and added a few more options in the build matrix.

One note about this PR: the expectedException annotation is no longer considered a best practice(https://thephp.cc/news/2016/02/questioning-phpunit-best-practices).

omissis commented 7 years ago

@padraic @theofidry I guess this one can be closed now that #32 has been merged.

padraic commented 7 years ago

Yep, just checking it merges to no changes ;)