2.0: Backwards compatibility breaking changes

humbug / phar-updater

A thing to make PHAR self-updates easy and secure

BSD 3-Clause "New" or "Revised" License

368 stars 27 forks source link

2.0: Backwards compatibility breaking changes #43

Open padraic opened 7 years ago

padraic commented 7 years ago

API updated: Constructor param order changed; Accept strategy objects as required param.
Tests and README updated.
Remove humbug_get_contents() as dependency.

TODO

[x] Rename setStrategyObject to setStrategy and remove older method.
[x] Set GithubStrategy to not upgrade to next major version by default.
[ ] Use file existence checks instead for error suppression on unlink() calls?
[x] Move SHA hash checks to ShaStrategyAbstract from Updater.

theofidry commented 7 years ago

We should create a new 1.x branch. Would it be possible to push the 256 strat to the 1.x?

padraic commented 7 years ago

I'm thinking there won't be another 1.x release, just a rolled up 2.0 release capturing all fixes and changes, so essentially it would be branching from the last tag to 1.x for posterity or a significant security issue.

theofidry commented 7 years ago

Hm, I would like to review in more details phar-updater before a 2.x, which would significantly delay it :/

padraic commented 7 years ago

@theofidry You can definitely take time to review it. I'm all out of PRs on this one, so whatever changes are currently in the PRs are it from my side.