search

humbug / phar-updater

A thing to make PHAR self-updates easy and secure
BSD 3-Clause "New" or "Revised" License
368 stars 27 forks source link

Replaced all humbug_get_contents with the namespaced one #46

Closed waltertamboer closed 7 years ago

waltertamboer commented 7 years ago

This PR fixes issue #45

waltertamboer commented 7 years ago

Fixed, Travis build is succeeding so not sure what you mean with the prefer lowest failing?

theofidry commented 7 years ago

Hm somehow it gets the 1.1.0 even if prefer lowest 🤔

waltertamboer commented 7 years ago

Thanks! Will require the dev-master for now so at least I can finish my project :)

wapmorgan commented 7 years ago

What about releasing a new version with these changes?

theofidry commented 7 years ago

It will be released when I'll find the time to do a round of phar-updater, either require dev-master or that specific commit if that's urgent meanwhile

padraic commented 7 years ago

We can release a new version, I think, for this change. It will get is over the deprecation notice for current usage while the other more significant PRs are being reviewed.

wapmorgan commented 7 years ago

I hope. Because currently it doesn't build out-of-the-box due to this notice.