search

humbug / phar-updater

A thing to make PHAR self-updates easy and secure
BSD 3-Clause "New" or "Revised" License
368 stars 27 forks source link

a problem in a dependend library causes the github strategy to fail on PHP versions < 5.6.0 #9

Open ppetermann opened 9 years ago

ppetermann commented 9 years ago

the issue described in: https://github.com/padraic/file_get_contents/issues/4

causes the github strategy (on PHP < 5.6.0) to fail with: file_get_contents(): Peer certificate CN=s3.amazonaws.com' did not match expected CN=github.com'

aik099 commented 8 years ago

Also having same problem. I see this haven't been fixes for almost 1 year now.

aik099 commented 8 years ago

I'm wondering why curl with same SSL peer verification (CURLOPT_SSL_VERIFYHOST option) can't be used instead of humbug_get_contents function/package.

aik099 commented 8 years ago

Here is what I've did in my library fork to get this working: https://github.com/console-helpers/phar-updater/commit/6dc6cdad0fe05c7d0a455017e44c636236c6d4de

padraic commented 7 years ago

Still needed?

Sorry for the delay, been AWOL.

aik099 commented 7 years ago

Sure. But this original issue that needs fixing is https://github.com/padraic/file_get_contents/issues/4. This issue is just a link so that we'll know that what's happening in here is result of an issue in a dependency.

theofidry commented 7 years ago

on a side note, would it make sense to move https://github.com/padraic/file_get_contents under the Humbug umbrella?

padraic commented 7 years ago

@theofidry Absolutely. I also have the github site for the PHAR downloads.

Edit: Transferred the file_get_contents repo and updated the Packagist site.