humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
37 stars 9 forks source link

Barlines in **mens #598

Open davidrizo opened 3 years ago

davidrizo commented 3 years ago

Sometimes barlines are shown in mensural scores. Currently, they are not displayed.

*M4/4
*met(C)
sa
=
*M2/2
*met(C|)
sb
*-

is displaying image

Is it possible to display the barline? Thanks, David

craigsapp commented 3 years ago

Implemented with commit https://github.com/rism-digital/verovio/commit/931c7f43c4ab2afe77597a9906f55eec0f6af632

Example:

Screen Shot 2021-06-20 at 10 05 19 PM

More complicated example:

Screen Shot 2021-06-20 at 10 15 36 PM
Humdrum data ```tsv **mens **mens *clefC3 *clefC3 *met(C) *met(C) =1 =1 Lc Sc . se . Mg . Mf = = Sd Mg . Mf . se = = se Sg sf . = = Sb Sb =|| =|| *- *- !!!verovio: spacingLinear 0.15 !!!verovio: spacingNonLinear 0.5 ```
MEI conversion ```xml </titleStmt> <pubStmt /> </fileDesc> <encodingDesc> <appInfo> <application isodate="2021-06-20T22:17:22" version="3.5.0-dev-931c7f4"> <name>Verovio</name> <p>Transcoded from Humdrum</p> </application> </appInfo> </encodingDesc> <workList> <work> <title /> </work> </workList> </meiHead> <music> <body> <mdiv xml:id="mdiv-0000001178395774"> <score xml:id="score-0000001944412294"> <scoreDef xml:id="scoredef-0000000032007619" midi.bpm="400"> <staffGrp xml:id="staffgrp-0000001564277668" bar.thru="true" symbol="brace"> <staffDef xml:id="staffdef-0000001802417810" n="1" notationtype="mensural.white" lines="5"> <clef xml:id="clef-L2F2" shape="C" line="3" /> </staffDef> <staffDef xml:id="staffdef-0000000077070325" n="2" notationtype="mensural.white" lines="5"> <clef xml:id="clef-L2F1" shape="C" line="3" /> </staffDef> </staffGrp> </scoreDef> <section xml:id="section-L1F1"> <staff xml:id="staff-0000001877443404" n="1"> <layer xml:id="layer-L1F2N1" n="1"> <mensur xml:id="mensur-L3F2" prolatio="2" tempus="2" sign="C" /> <note xml:id="note-L5F2" dur="brevis" oct="4" pname="c" /> <note xml:id="note-L6F2" dur="semibrevis" oct="4" pname="e" /> <note xml:id="note-L7F2" dur="minima" oct="4" pname="g" /> <note xml:id="note-L8F2" dur="minima" oct="4" pname="f" /> <barLine xml:id="barline-L9F2" /> <note xml:id="note-L10F2" dur="minima" oct="4" pname="g" /> <note xml:id="note-L11F2" dur="minima" oct="4" pname="f" /> <note xml:id="note-L12F2" dur="semibrevis" oct="4" pname="e" /> <barLine xml:id="barline-L13F2" /> <note xml:id="note-L14F2" dur="brevis" oct="4" pname="g" /> <barLine xml:id="barline-L16F2" /> <note xml:id="note-L17F2" dur="brevis" oct="4" pname="b" /> <barLine xml:id="barline-L18F2" form="dbl" /> </layer> </staff> <staff xml:id="staff-0000000137548722" n="2"> <layer xml:id="layer-L1F1N1" n="1"> <mensur xml:id="mensur-L3F1" prolatio="2" tempus="2" sign="C" /> <note xml:id="note-L5F1" dur="longa" oct="4" pname="c" /> <barLine xml:id="barline-L9F1" /> <note xml:id="note-L10F1" dur="brevis" oct="4" pname="d" /> <barLine xml:id="barline-L13F1" /> <note xml:id="note-L14F1" dur="semibrevis" oct="4" pname="e" /> <note xml:id="note-L15F1" dur="semibrevis" oct="4" pname="f" /> <barLine xml:id="barline-L16F1" /> <note xml:id="note-L17F1" dur="brevis" oct="4" pname="b" /> <barLine xml:id="barline-L18F1" form="dbl" /> </layer> </staff> </section> </score> </mdiv> </body> </music> </mei> ``` </details> <p>There seems to be a bug in the placement of barlines between staves in verovio, @lpugin? The notes are aligned as expected, but the barlines should also be aligning. The barline following the shorter duration in a measure is placed after the shorter note rather than before the note in the next measure.</p> <hr /> <p>Further refinements could be done such as suppressing barlines that split the duration of a note (such as could be the case with the long note in the first measure which takes two measures at the breve barring.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/craigsapp"><img src="https://avatars.githubusercontent.com/u/3487289?v=4" />craigsapp</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Note that it is not necessary to insert a time signature before a mensuration sign in <code>**mens</code> to display the mensuration sign. And in this case the time signatures are better represented as <code>*M2/1</code> for the duration of a breve.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>