humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
38 stars 9 forks source link

Issues with composite #650

Open VenomousLampshade opened 2 years ago

VenomousLampshade commented 2 years ago

Under VHV, the composite filter no longer works. This is a very recent change, as it was working a couple days ago.

craigsapp commented 2 years ago

Yes, I just put a new version of composite online today as you are noticing. The old one is called compositeold and the new one is called composite. For some reason the old one is not working (which is not surprising since I did not test it out before renaming it — I will sort that out, since it is useful for comparing to the new version).

There are a few changes in the options for the new version (which is basically a total rewrite of the old program).

The first thing I notice, is that the filter composite by itself generates the pink notation as it does for you. I will fix this problem. The intended behavior is that the full composite rhythm will be shown under the input score. This is different from the original program, where the group A/B composite rhythms were instead shown by default.

So to get the original behavior with the new composite filter, try these options:

composite -Fg

The -F option suppresses the full composite analysis, and the -g option does the group A/B analysis:

http://verovio.humdrum.org/?file=poly/R129_Jan-w30p11m124-127.krn&filter=composite%20-Fg%20%7C%20colorgroups

Screen Shot 2022-02-28 at 11 34 27 PM

Here is an example of more options in the new version:

http://verovio.humdrum.org/?file=poly/R129_Jan-w30p11m124-127.krn&filter=composite%20-gcmu%20%7C%20colorgroups

Screen Shot 2022-02-28 at 11 37 57 PM

-g means do the group A/B analysis

-c means do the coincidence analysis (whenever A and B both have notes).

lack of -F means do the full composite (union of group A and B).

-u means stems up on the analysis parts (I need to add to coincidence analysis staff).

-m means mark coincidence notes in the music or full/group analyses in green.

craigsapp commented 2 years ago

Going to Analysis > Composite rhythm > Composite rhythm no longer produces any result.

I will need to update the menu entries for the composite tool.

craigsapp commented 2 years ago

The plain filter composite is now working again:

http://verovio.humdrum.org/?file=poly/R129_Jan-w30p11m124-127.krn&filter=composite

Screen Shot 2022-03-01 at 12 02 10 AM

This will analyze the "full" composite rhythm. Previously the "group" composite rhythms would be analyzed instead if there were *grp:A and *grp:B labels in the score.

To do both full and group analyses:

http://verovio.humdrum.org/?file=poly/R129_Jan-w30p11m124-127.krn&filter=composite%20-g

Screen Shot 2022-03-01 at 12 04 17 AM

To do only "group" analysis:

http://verovio.humdrum.org/?file=poly/R129_Jan-w30p11m124-127.krn&filter=composite%20-gF

Screen Shot 2022-03-01 at 12 05 18 AM