search

humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
37 stars 9 forks source link

**cdata is always displayed below the system #802

Closed craigsapp closed 1 year ago

craigsapp commented 1 year ago

Probably related to work on **fb, **cdata is now always shown below the system. But for the dissonant tool, it should be displayed on the part:

https://verovio.humdrum.org/?file=jrp/Jos/Jos2408-Obsecro_te_domina.krn&filter=dissonant&v=evenNoteSpacing

Screenshot 2023-03-20 at 2 25 22 PM

Having the dissonant analysis groups under the system is interesting, but it will primarily needs to be placed on the parts.  

@WolfgangDrescher I presume this is your doing somehow? In any case, I can fix it and make an exception if needed for fb/**fb.

WolfgangDrescher commented 1 year ago

The problem was in https://github.com/rism-digital/verovio/commit/2c0ca365ddb30a76829268d0c8d3abdb6d8e34a1. track = token->getTrack(); was set for every field while before it was in a if (token->isKernLike()) { track = token->getTrack(); } condition. I have not tested for other cases. But there is no other occurrence of track in addHarmFloatsForMeasure. So it should be fine.