humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
37 stars 9 forks source link

collision slurs + length #81

Closed derkveen closed 6 years ago

derkveen commented 6 years ago

It would be nice if it would be possible that slurs never collide. Also the starting and ending of a slur not beamside is maybe nicer not to be calculated from the centre of the note head, which, maybe, is now the case. Slurs are now limited to 9 notes when using the keyboard, whilst in the text-editor it's unlimited. WHen slurs are very long they are become less attractive. The last red circle should be the end of the slur which started at the beginning of bar 9. Both examples:

example1 example2

craigsapp commented 6 years ago

It would be nice if it would be possible that slurs never collide.

This is related to issue: https://github.com/rism-ch/verovio/issues/454

Slurs are now limited to 9 notes when using the keyboard, whilst in the text-editor it's unlimited.

True. I do not want the #s system to extend to longer slurs, as it would make incorrect slurs easer to add accidentally. The current graphical method to extend slurs longer is described here:http://doc.verovio.humdrum.org/graphic/slurs/#moving-slurs where you use the left/right arrows to shift one side of the slur and shift-left/right arrows to extend the other side of the slur. Moving slurs in piano music where voices pop in and out is currently problematic, and crossing slurs graphically does not behave properly. (So complicated slur arrangements may remain text-editing based only).

My current idea is to allow another graphical slur insertion method where you click on the first note, and then shift-click on the second note then type the letter s to add a slur to those two notes. There will be problems with that system if there are slur cross-overs, but for non-crossing slurs it will work well.

WHen slurs are very long they are become less attractive.

That is difficult to get right automatically, and is more of a verovio feature request than verovio-humdrum viewer one 😉

Also the starting and ending of a slur not beamside is maybe nicer not to be calculated from the centre of the note head,

Your highlighting of the stems of the two 16th notes related to the incorrectly justified slur is related to this issue: https://github.com/rism-ch/verovio/issues/225 Verovio has recently improved justification of slurs on the stem sides of notes, but there is a remaining problem when the length of the slur is short.

The last red circle should be the end of the slur which started at the beginning of bar 9.

I think that this is covered with issue https://github.com/rism-ch/verovio/issues/227 . Single system breaks across system was fixed, but breaks across multiple systems still needs to be implemented. This may be a corner case where there is a problem if the ending note is at the start of a new system. I will study the behavior and add that case to the above issue if so.

craigsapp commented 6 years ago

I have added a feature request for allowing graphical insertion of long slurs: https://github.com/humdrum-tools/verovio-humdrum-viewer/issues/82

derkveen commented 6 years ago

Hi Graig,

Thanks. I will first try it out via de xml-uploader of the verovio viewer, to see if it's a verovio issue.

I have a question about the vhv by the way. If I go to your vhv website entering https instead of http, the .knr doesn't load. The same problem on my website, which is https. I can work with it using http, but in the end I need it in be https. Do you know how we can solve this? I checked for http links, but could not find them. Also I didn't find something about it on the gihub pages.

Kind regards, Derk

2018-04-08 18:32 GMT+02:00 Craig Stuart Sapp notifications@github.com:

I have added a feature request for allowing graphical insertion of long slurs: #82 https://github.com/humdrum-tools/verovio-humdrum-viewer/issues/82

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/humdrum-tools/verovio-humdrum-viewer/issues/81#issuecomment-379563300, or mute the thread https://github.com/notifications/unsubscribe-auth/ATo7mjLu6JSdJ945yznVUookdxCb7dT9ks5tmju1gaJpZM4TLfwG .