humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
37 stars 9 forks source link

Tempo control not working #819

Closed craigsapp closed 1 year ago

craigsapp commented 1 year ago

Tempos of music are now always 120 quarter notes / minute. This is due most likely to recent updates in verovio (so either the humdrum converter needs updating or there is a bug in verovio).

Screenshot 2023-06-20 at 7 39 12 AM
**kern  **kern
*M4/4   *M4/4
*MM20   *MM20
=1  =1
4C  4cc
4C  4cc
4C  4cc
4C  4cc
=2  =2
4C  4cc
4C  4cc
4C  4cc
4C  4cc
==  ==
*-  *-

Setting MM20 to any value will always result in the equivalent to MM120 being the tempo.

Click for current conversion to MEI ```xml </titleStmt> <pubStmt /> </fileDesc> <encodingDesc> <appInfo> <application isodate="2023-06-20T07:32:38" version="3.16.0-dev-b21091b"> <name>Verovio</name> <p>Transcoded from Humdrum</p> </application> </appInfo> </encodingDesc> <workList> <work> <title /> </work> </workList> </meiHead> <music> <body> <mdiv xml:id="m1gmwh72"> <score xml:id="sitao8z"> <scoreDef xml:id="sd3b2z8" midi.bpm="20.000000"> <staffGrp xml:id="swlpe0b" bar.thru="true" symbol="brace"> <staffDef xml:id="staffdef-L1F2" n="1" lines="5"> <clef xml:id="c3fdo1y" shape="G" line="2" /> <meterSig xml:id="metersig-L2F2" count="4" unit="4" /> </staffDef> <staffDef xml:id="staffdef-L1F1" n="2" lines="5"> <clef xml:id="c6qs33b" shape="F" line="4" /> <meterSig xml:id="metersig-L2F1" count="4" unit="4" /> </staffDef> </staffGrp> </scoreDef> <section xml:id="section-L1F1"> <measure xml:id="measure-L1" n="1"> <staff xml:id="staff-L1F2" n="1"> <layer xml:id="layer-L1F2N1" n="1"> <note xml:id="note-L5F2" dur="4" oct="5" pname="c" accid.ges="n" /> <note xml:id="note-L6F2" dur="4" oct="5" pname="c" accid.ges="n" /> <note xml:id="note-L7F2" dur="4" oct="5" pname="c" accid.ges="n" /> <note xml:id="note-L8F2" dur="4" oct="5" pname="c" accid.ges="n" /> </layer> </staff> <staff xml:id="staff-L1F1" n="2"> <layer xml:id="layer-L1F1N1" n="1"> <note xml:id="note-L5F1" dur="4" oct="3" pname="c" accid.ges="n" /> <note xml:id="note-L6F1" dur="4" oct="3" pname="c" accid.ges="n" /> <note xml:id="note-L7F1" dur="4" oct="3" pname="c" accid.ges="n" /> <note xml:id="note-L8F1" dur="4" oct="3" pname="c" accid.ges="n" /> </layer> </staff> </measure> <measure xml:id="measure-L9" right="end" n="2"> <staff xml:id="staff-L9F2N1" n="1"> <layer xml:id="layer-L9F2N1" n="1"> <note xml:id="note-L10F2" dur="4" oct="5" pname="c" accid.ges="n" /> <note xml:id="note-L11F2" dur="4" oct="5" pname="c" accid.ges="n" /> <note xml:id="note-L12F2" dur="4" oct="5" pname="c" accid.ges="n" /> <note xml:id="note-L13F2" dur="4" oct="5" pname="c" accid.ges="n" /> </layer> </staff> <staff xml:id="staff-L9F1N1" n="2"> <layer xml:id="layer-L9F1N1" n="1"> <note xml:id="note-L10F1" dur="4" oct="3" pname="c" accid.ges="n" /> <note xml:id="note-L11F1" dur="4" oct="3" pname="c" accid.ges="n" /> <note xml:id="note-L12F1" dur="4" oct="3" pname="c" accid.ges="n" /> <note xml:id="note-L13F1" dur="4" oct="3" pname="c" accid.ges="n" /> </layer> </staff> </measure> </section> </score> </mdiv> </body> </music> </mei> ``` </details> <p>The tempo information seems correct, unless it should now be expressed differently:</p> <pre><code class="language-xml"><scoreDef xml:id="sd3b2z8" midi.bpm="20.000000"></code></pre> <p>The timemap output from verovio for the MEI data is incorrectly outputting music in MM120:</p> <details> <summary> Click to view timemap </summary> ```json [ { "on": [ "note-L5F2", "note-L5F1" ], "qstamp": 0, "tempo": "120.000000", "tstamp": 0 }, { "off": [ "note-L5F2", "note-L5F1" ], "on": [ "note-L6F2", "note-L6F1" ], "qstamp": 1, "tstamp": 500 }, { "off": [ "note-L6F2", "note-L6F1" ], "on": [ "note-L7F2", "note-L7F1" ], "qstamp": 2, "tstamp": 1000 }, { "off": [ "note-L7F2", "note-L7F1" ], "on": [ "note-L8F2", "note-L8F1" ], "qstamp": 3, "tstamp": 1500 }, { "off": [ "note-L8F2", "note-L8F1" ], "qstamp": 4, "tstamp": 2000 }, { "on": [ "note-L10F2", "note-L10F1" ], "qstamp": 4, "tstamp": 12000 }, { "off": [ "note-L10F2", "note-L10F1" ], "on": [ "note-L11F2", "note-L11F1" ], "qstamp": 5, "tstamp": 12500 }, { "off": [ "note-L11F2", "note-L11F1" ], "on": [ "note-L12F2", "note-L12F1" ], "qstamp": 6, "tstamp": 13000 }, { "off": [ "note-L12F2", "note-L12F1" ], "on": [ "note-L13F2", "note-L13F1" ], "qstamp": 7, "tstamp": 13500 }, { "off": [ "note-L13F2", "note-L13F1" ], "qstamp": 8, "tstamp": 14000 } ] ``` </details> <p>The tempo in the timemap is 120:</p> <pre><code class="language-json"> "tempo": "120.000000",</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/craigsapp"><img src="https://avatars.githubusercontent.com/u/3487289?v=4" />craigsapp</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Reported in issue <a href="https://github.com/rism-digital/verovio/issues/3457">https://github.com/rism-digital/verovio/issues/3457</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/craigsapp"><img src="https://avatars.githubusercontent.com/u/3487289?v=4" />craigsapp</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Now fixed in verovio (and updated in VHV).</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>