humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
37 stars 9 forks source link

Dynamics are displayed one staff too low when spine is split #823

Closed jacekiwaszko1 closed 1 year ago

jacekiwaszko1 commented 1 year ago

When there's a split in **dynam spine, dynamics encoded there are displayed one staff too low:

**kern  **kern  **dynam
*   *^  *^
4d  4cc 4c  p   pp
*   *   *   *v  *v
*   *v  *v  *
*-  *-  *-

Current rendering:

image

In MEI conversion there's dynam@place=2 for pp, where there should be dynam@place=1, as for p:

Click here to see MEI encoding ```xml </titleStmt> <pubStmt /> </fileDesc> <encodingDesc> <appInfo> <application isodate="2023-08-07T11:14:47" version="3.17.0-dev-2ff7066"> <name>Verovio</name> <p>Transcoded from Humdrum</p> </application> </appInfo> </encodingDesc> <workList> <work> <title /> </work> </workList> </meiHead> <music> <body> <mdiv xml:id="m1qrsjy3"> <score xml:id="swhd0m7"> <scoreDef xml:id="svvajsf"> <staffGrp xml:id="s1ofj4qq" bar.thru="true" symbol="brace"> <staffDef xml:id="staffdef-L1F2" n="1" lines="5"> <clef xml:id="chvhdbc" shape="G" line="2" /> </staffDef> <staffDef xml:id="staffdef-L1F1" n="2" lines="5"> <clef xml:id="ciipgz6" shape="G" line="2" /> </staffDef> </staffGrp> </scoreDef> <section xml:id="section-L1F1"> <measure xml:id="measure-L1" right="invis"> <staff xml:id="staff-L1F2" n="1"> <layer xml:id="layer-L1F2N1" n="1"> <note xml:id="note-L3F2" dur="4" oct="5" pname="c" accid.ges="n" /> </layer> <layer xml:id="layer-L1F3N2" n="2"> <note xml:id="note-L3F3" dur="4" oct="4" pname="c" accid.ges="n" /> </layer> </staff> <staff xml:id="staff-L1F1" n="2"> <layer xml:id="layer-L1F1N1" n="1"> <note xml:id="note-L3F1" dur="4" oct="4" pname="d" accid.ges="n" /> </layer> </staff> <dynam xml:id="dynam-L3F4" place="above" staff="1" tstamp="1.000000" vgrp="100">p</dynam> <dynam xml:id="dynam-L3F5" place="below" staff="2" tstamp="1.000000" vgrp="100">pp</dynam> </measure> </section> </score> </mdiv> </body> </music> </mei> ``` </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/craigsapp"><img src="https://avatars.githubusercontent.com/u/3487289?v=4" />craigsapp</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Fixed in commit <a href="https://github.com/rism-digital/verovio/commit/4ffe18a9371122251d65e178d3b6182dd936d828">https://github.com/rism-digital/verovio/commit/4ffe18a9371122251d65e178d3b6182dd936d828</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/craigsapp"><img src="https://avatars.githubusercontent.com/u/3487289?v=4" />craigsapp</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <img width="948" alt="Screenshot 2023-08-08 at 12 58 12" src="https://github.com/humdrum-tools/verovio-humdrum-viewer/assets/3487289/f74fd51c-7713-4470-af94-6c8d556f8468"> <p><a href="https://verovio.humdrum.org?t=KiprZXJuCSoqa2VybgkqKmR5bmFtCioJKl4JKl4KNGQJNGNjCTRjCXAJcHAKKgkqCSoJKnYJKnYKKgkqdgkqdgkqCiotCSotCSotCg">https://verovio.humdrum.org?t=KiprZXJuCSoqa2VybgkqKmR5bmFtCioJKl4JKl4KNGQJNGNjCTRjCXAJcHAKKgkqCSoJKnYJKnYKKgkqdgkqdgkqCiotCSotCSotCg</a>==</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>