humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
36 stars 9 forks source link

Hairpins in subspines #862

Closed andrzejkubiczek closed 8 months ago

andrzejkubiczek commented 8 months ago

I need to split the **dynam spine in the vocal part to add the second cresc. marking. Unfortunately the right subspine cannot be placed above the staff, LO:HP:a doesn't work. Other dynamics markings are correctly placed above the staff in subspines.

humdrum

source

**kern  **kern  **dynam **kern  **text  **text  **dynam
*part2  *part2  *part2  *part1  *part1  *part1  *part1
*staff3 *staff2 *staff2/3   *staff1 *staff1 *staff1 *staff1
*ICklav *ICklav *   *ICvox  *   *   *
*Ipiano *Ipiano *   *Isoprn *   *   *
*I" *I" *   *I" *   *   *
*I' *I' *   *I' *   *   *
*clefF4 *clefG2 *   *clefG2 *   *   *
*k[]    *k[]    *   *k[]    *   *   *
*M6/8   *M6/8   *   *M6/8   *   *   *
=20 =20 =20 =20 =20 =20 =20
*   *^  *   *   *   *   *^
(8.BBB-X/L  (4en 4En/   4.d-X 4.B-X\    p   4en/    mei-    u-  p < .
16DD-X/K    .   .   .   .   .   .   .   .
!   !   !   !LO:HP:t=molto cresc.   !   !   !   !   !
8D-X/J) 8f 8F/  .   <   8f/ -nen    -szach  .   .
!   !   !   !   !   !   !   !   !LO:HP:a
4.AAn 4.DDn 4.AAAn/ 4f#X 4F#X/  4.dn 4.An\  .   4f#X/   Oh- tak .   <
.   16e#XLL 16E#X/  .   .   8a/ -ren    się [   .
.   16f#JJ 16F#/    .   .   .   .   .   .   .
*   *   *   *   *   *   *   *v  *v
=21 =21 =21 =21 =21 =21 =21 =21
*^  *   *   *   *   *   *   *
(8.DDnL 8.DDDn/ 8.ryy   4g#X 4G#X/  4.f#X 4.dn\ f   4dd\    klagt   skar-   f
16AAn/K [8.AA\  .   .   .   .   .   .   .
[8An/J  .   8an 8An/)   .   .   8dd\    mein    -ży .
!   !   !LO:TX:b:i:t=rit.   !   !   !   !   !   !
8.A]L 8.AA/])   8.ryy   4.b-X 4.fn 4.B-X/   4.ryy   .   4.ffn^\ Blut,   Krew,   .
16AA-X/K    (8.AA-\ .   .   .   .   .   .   .
8A-X/J) .   .   .   .   .   .   .   .
=22 =22 =22 =22 =22 =22 =22 =22 =22
*   *   *   *   *   *^  *   *   *
!   !   !   !   !LO:DY:t=sub. %s    !   !   !   !   !
(8.DDn/L    8.ryy   (4g#X 4G#X/ 4.f#X 4.dn\ pp  4r  8d\ .   tak,    .
.   .   .   .   .   .   8r  .   .   .
16AAn/K [8.AA\  .   .   .   .   .   .   .   .
[8An/J  .   8an 8An/    .   .   8d/ 2ryy    mein    to  pp
!   !   !   !   !   !LO:TUP:a:problem=klamra łukowa !   !   !   !
8.A]L 8.AA/])   8.ryy   4.b-X 4.fn 4.B-X/)  4.ryy   .   [16%3fn/    .   Blut    krew.   .
!LO:TX:a:i:t=rit.   !   !   !   !   !   !   !   !   !
16AA-X/K    (8.AA-\ .   .   .   16%3f/] .   wohl.   .   .
8A-X/J) .   .   .   .   .   .   .   .   .
*v  *v  *   *   *   *v  *v  *   *   *
!!LO:PB:g=original
=23 =23 =23 =23 =23 =23 =23 =23
!   !   !   !LO:DY:rj   !   !   !   !
!   !LO:TX:a:i:t=Avvivando. !   !LO:HP:t=molto cresc.   !   !   !   !
(8.EE-X/L   4an 4An/    (4.g-X 4.e-X\   p < 4r  .   .   .
16GG-X/K    .   .   .   .   .   .   .
8G-X/J) 8b-X 8B-X/  .   .   8r  .   .   .
(8.DDn/L    4bn 4Bn/    4.gn 4.dn\  .   4r  .   .   .
16GGn/K .   .   .   .   .   .   .
8Gn/J)  16a#XLL 16A#X/  .   .   8dn/    Mein    Lecz    .
.   16bJJ 16B/  .   .   .   .   .   .
=24 =24 =24 =24 =24 =24 =24 =24
*   *   *   *   *^  *   *   *
!   !   !   !   !LO:TUP:a:problem=klamra łukowa !   !   !   !
(8.GGnL 8.GGGn/ 4cc#X 4c#X/ 4.bn 4.gn\  <   16%3cc#X\   4.ryy   Blut    Krew    .
16BBn/K .   .   .   16%3dd\ .   klingt  nie <
8Bn/J)  8dd 8d/ .   .   .   .   .   .   .
(8.GG-XL 8.GGG-X/   4.ee-X 4.b-X 4.e-X/)    4.ryy   [   4ee-X/  8.ee-\  a-  Ża- .
16BB-X/K    .   .   .   .   16ee-\  .   -li .
8B-X/J) .   .   .   8b/ 8b\ -ber    się [
*   *   *   *   *v  *v  *   *   *
*-  *-  *-  *-  *-  *-  *-  *-
!!!system-decoration: <vox>{(klav)}
!!!RDF**kern: > = above
!!!RDF**kern: < = below
craigsapp commented 8 months ago

Interestingly, the cresc. mark is placed properly when the vocal part is extracted:

Screenshot 2023-10-25 at 10 21 27

View in VHV

When there is a staff below the staff of the cresc. mark, it is being moved to the staff below (2):

<dir xml:id="dir-L18F9" place="above" staff="2" tstamp="4.000000">cresc.</dir>
craigsapp commented 8 months ago

Fixed with commit https://github.com/rism-digital/verovio/commit/8609592d5a34efa7d1c194b6cb60fe06e755ce20

New rendering properly:

Screenshot 2023-10-25 at 11 58 01

For placement of cresc. within the hairpin see issue https://github.com/music-encoding/music-encoding/issues/1385

craigsapp commented 8 months ago

Now renders as:

Screenshot 2023-10-25 at 12 29 48
craigsapp commented 8 months ago

See issue https://github.com/music-encoding/music-encoding/issues/1385 for placement of cresc. inside of hairpin.