humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
37 stars 9 forks source link

Incorrect linking of hairpin endpoints #863

Closed craigsapp closed 11 months ago

craigsapp commented 11 months ago

In this example:

Screenshot 2023-10-25 at 10 44 16

There should be a cresc. under the second note of the second measure. Instead the cresc. finds an ending [ in the next measure that it should not (in particular since it is already owned by another <. Make it so that < and ] cannot be matched when they are in different subspines (other than subspines 0/1).

Test data:

**kern  **dynam
1c  p <
1d  [[
=   =
*   *^
1c  p < .
1d  .   <
1e  [   .
*   *v  *v
=   =
*   *^
1c  p < .
!   !   !LO:HP:a
1d  .   <
1e  [   .
*   *v  *v
*-  *-
craigsapp commented 11 months ago

Fixed with commit https://github.com/rism-digital/verovio/commit/992524465a6de956204fb7d69424207514fe1f1c

Screenshot 2023-10-25 at 11 12 50

Also works with decrescendos:

Screenshot 2023-10-25 at 11 13 27
**kern  **dynam
1c  f >
1d  ]]
=   =
*   *^
1c  f > .
1d  .   >
1e  ]   .
*   *v  *v
=   =
*   *^
1c  f > .
!   !   !LO:HP:a
1d  .   >
1e  ]   .
*   *v  *v
*-  *-