humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
36 stars 9 forks source link

Bracketed instrument name not showing #875

Closed craigsapp closed 5 months ago

craigsapp commented 5 months ago

Example:

Screenshot 2024-01-21 at 19 18 54

View in VHV

Removing the dot will make is show:

Screenshot 2024-01-21 at 19 20 04

View in VHV

craigsapp commented 5 months ago

This also affects text in square brackets that ends in a period:

Screenshot 2024-01-22 at 23 58 04

View in VHV

In this case, only a . is displayed (while for instrument names nothing is shown).

craigsapp commented 5 months ago

The problem is that [text.] is converted into an augmentation dot symbol in the MEI conversion:

                     <tempo xml:id="tempo-L1F1" staff="1" tstamp="1.000000">
                        <symbol xml:id="s481dam" glyph.auth="smufl" glyph.name="metAugmentationDot" fontsize="70.00%" />
                     </tempo>

Using . inside of square brackets should excluded for consideration of converting into a symbol. If needed, then [dot] should be used (and implemented if necessary). Also [quarter-dot] is already implemented for dotted quarter notes.

craigsapp commented 5 months ago

Fixed in commit https://github.com/rism-digital/verovio/commit/f8e270ee7a38e45d258ca3e027994c39c428fbdc

Example:

!!!OMD: [Allegro.]
**kern
*I"[alto.]
!LO:TX:b:t=[text.]
1c
=
*-

Renders now as:

Screenshot 2024-01-23 at 00 24 23
Click to view MEI conversion of above Humdrum data ```xml [Allegro.] This MEI file was created by Verovio's Humdrum converter. When published, this unpub element should be removed, and the enclosing pubStmt element should be properly filled out. Verovio

Transcoded from Humdrum

<titlePart type="movementName" analog="humdrum:OMD">[Allegro.]</titlePart> reference OMD [Allegro.]
[Allegro.] [text.]
```