humdrum-tools / verovio-humdrum-viewer

Verovio Humdrum Viewer
http://verovio.humdrum.org
38 stars 9 forks source link

filter tool doesn't activate the encoded filters #895

Closed jacekiwaszko1 closed 6 months ago

jacekiwaszko1 commented 6 months ago

The filter tool should activate the filter encoded in the file, but it isn't working now.

**kern  **kern
1c  1cc
=   =
*-  *-
!!!filter-test: extract -s 1
!!!filter: filter -v test

After adding the filter -v test to the code above it should be rendered as single staff due to extract -s 1, but nothing changes:

image

After compiling, the HTML code with the help page is added at the beginning of the file, as if the option -v was not recognized:

!!@@BEGIN: PREHTML
!!<table>
!!   <tr>
!!      <th>Option</th><th>Type</th><th>Default</th><th>Description</th>
!!   </tr>
!!   <tr>
!!     <td>--debug</td><td>boolean </td><td>boolean </td><td> </td><td>print debug statement </td>
!!   </tr>
!!   <tr>
!!     <td>-v</td><td>string </td><td>string </td><td> </td><td>Run filters labeled with the given variant </td>
!!   </tr>
!!</table>
!!@@END: PREHTML
**kern  **kern
1c  1cc
=   =
*-  *-
!!!filter-test: extract -s 1
!!!Xfilter: filter -v test
craigsapp commented 6 months ago

Fixed:

Screenshot 2024-05-14 at 4 42 23 AM

I was testing how to display options for a filter above the notation (but it was not finished when I got distracted and somehow it activated with the filter filter). I have removed the code for now and things are behaving for me (and should on the POPC2 website and VHV).