search

humhub-contrib / gallery

7 stars 11 forks source link

Update stylings of header and footer #102

Closed Kikketer closed 2 years ago

Kikketer commented 2 years ago

Due to visual oddities the white text for the gallery items is not easily visible most of the time. This also breaks accessibility contrast rules.

This PR updates to have a minimum background color for the header and footer that passes accessibility contrast rules (transparent over white background with white text).

Result

luke- commented 2 years ago

@Kikketer Awesome! Thanks looks good. Can you please add the change in the changelog? I would then publish a module release in the next days.

Kikketer commented 2 years ago

Updated! Thank you.

Kikketer commented 2 years ago

@luke- I noticed some tests have failed: https://github.com/humhub-contrib/gallery/actions/runs/2488758312 Sorry if that's my bad, I'm still learning how this repo works and didn't think a less/css change would cause a failure. I could start another PR to hopefully clear up those tests but it'll take a bit as I learn how that all works.

I don't even have PHP installed locally (yet), I was just messing with the rendered pages and adjusted the styles based on that.