search

humhub-contrib / gallery

7 stars 11 forks source link

Fix Tests #89

Closed luke- closed 2 years ago

yurabakhtin commented 2 years ago

@luke- PR https://github.com/humhub-contrib/gallery/pull/90. Please note the test errors look strange because locally I couldn't reproduce them, and only after several tryings(you can find 5 commits there) I could get the test checks without errors, but I am not sure they will not appear in future.

luke- commented 2 years ago

@yurabakhtin Ok, thanks!

luke- commented 2 years ago

Hmm see here: https://github.com/humhub-contrib/gallery/runs/4351949198?check_suite_focus=true

yurabakhtin commented 2 years ago

@luke- As I wrote above "I am not sure they will not appear in future", I mean the errors are float i.e. sometimes the tests run without errors like you can see for the 3 first cases: PHP 7.4 + develop, PHP 7.4 + master, PHP 8.0 + develop, but the last PHP 8.0 + master is broken by some unknown reason. Even if you see the errors, it looks like old/cached code is executed:

test_code

On my local server I cannot reproduce the errors:

gallery_test

Do you have any idea? Maybe some temp problems on the server where the tests are executed...

luke- commented 2 years ago

@yurabakhtin I tried this: https://github.com/humhub-contrib/gallery/commit/03471a2f9b1ffe6b6f308172816c34c6f4b90a3a Currently the tests are running and I don't see a impact on the speed/duration with my change. Let's keep monitoring it.