humhub-contrib / jitsi-meet

6 stars 7 forks source link

Group Permission #35

Closed Semir1212 closed 9 months ago

Semir1212 commented 11 months ago

Add group permission "Can access Jitsi Meet from main navigation".

Semir1212 commented 9 months ago

The permission was supposed to hinder users from creating Jitsi rooms via the main navigation, but as it seems it prevents users from accessing Jitsi at all. Users basically need a permission to create a Jitsi room in order to be able to join one.

We should change the existing permission to either "Can see Jitsi Meet in navigation" and remove the existing limitation, or ideally to "Can access humhub.com/jitsi-meet/room / Can create Jitsi Meetings". In any case, users need to be able to join a meeting if the have the link to it, regardless of the permission.

Can you take a look into this @yurabakhtin ?

yurabakhtin commented 9 months ago

@Semir1212 Ok, I have fixed this in PR https://github.com/humhub-contrib/jitsi-meet/pull/37, now the permission works only to hide the top menu item "Jitsi Meet" and don't allow access to the action /jitsi-meet/room, all other actions to view already created rooms are not restricted for any users.

luke- commented 9 months ago

Merged and released