humhub-contrib / legal

2 stars 9 forks source link

Enh: Add Cookie Policy page #34

Closed ArchBlood closed 1 year ago

ArchBlood commented 3 years ago

Please review and see if this is something that should be added versus what shouldn't be added

fixes #21

Notes

I'd like to add once more for a note about mobile view vs desktop view seen here https://github.com/humhub-contrib/legal/issues/21#issuecomment-882117064

ArchBlood commented 3 years ago

@luke- here's the rundown of the implementation of the Cookie Policy, it works just like other pages and is then added to the footer along with the other enabled options, personally, I'd rather implement it in a way where it only displays in a specific place but for now, this should do exactly what it's needed. 🤔

ArchBlood commented 3 years ago

A thought, instead of adding it to the footer section, maybe only display this on the Cookie notice?

luke- commented 1 year ago

I would prefer to add such additional footer pages via the Custom Pages module instead of covering such cases via the Legal Pages module.

ArchBlood commented 1 year ago

I would prefer to add such additional footer pages via the Custom Pages module instead of covering such cases via the Legal Pages module.

Hmm, in that case, would it be possible to implement such a thing into the footer though the custom pages module, currently I'm not seeing an option for this as of yet.

Overall the idea of placing a clickable link in the notice itself should still suffice. :thinking:

luke- commented 1 year ago

This option: image

ArchBlood commented 1 year ago

This option: image

In this case, would it be possible to update the footer menu where it's implemented in a way similar to how Facebook has theirs? This could fix some of the UI downsides to adding multiple options to the footer.

luke- commented 1 year ago

What downsides do you mean? If there are things to improve about the footer menu, we can create an issue.

ArchBlood commented 1 year ago

On mobile view with multiple options in the footer it can become very cluttered and if too many links are placed then the display is very displeasing and looks stretched out.