humhub / app

20 stars 8 forks source link

Opening the app from a link opens the page in a new "tab" of the app #139

Closed marc-farre closed 8 months ago

marc-farre commented 10 months ago

In some cases, when clicking on a link (e.g. an email from Humhub), the page opens in the app, but in a sort of new "tab" inside the app.

It seams to happen in 2 situations:

Screenshot_20231108_151224_com humhub app Screenshot_20231108_151229_com humhub app

marc-farre commented 10 months ago

@PrimozRatej I've also managed to open the app several times by clicking on links in email notifications. When I look at the "opened apps", I can see multiple Humhub apps.

PrimozRatej commented 10 months ago

Hey @marc-farre, could you please provide me with a screenshot for this?

marc-farre commented 10 months ago

@PrimozRatej On this screenshot: Screenshot_20231110_173543_com huawei android launcher resized

1) is the first launch of the app on the desktop 2) is the second instance of the app, opened when clicking on a link of an email notification

It seams that:

If you want to try, you can create an account on the https://demo.cuzy.app/ instance here: https://www.cuzy.app/try/

luke- commented 10 months ago

@PrimozRatej Thanks! @marc-farre Can you please test with v1.0.83

marc-farre commented 10 months ago

@PrimozRatej thanks! It makes it a lot better!

What happen when I test:

So first tests weren't perfect, but now it works well, I don't know why.

marc-farre commented 10 months ago

After a while, I had to enter again the login / password.

Another thing: if I'm on instance 1 and there is a mobile notification about instance 2, after clicking on this notification, the mobile app opens, but stay on instance 1. Then, if I click on the email notification link, it opens correctly the instance 2.

PrimozRatej commented 10 months ago

Hey @marc-farre about the test case, sounds to me like a cache problem, can you try to clear it? About push notifications redirects, looking into it.

marc-farre commented 10 months ago

sounds to me like a cache problem

Yes, could be. Today I have no bug! I'll try later.

PrimozRatej commented 10 months ago

Hey @marc-farre, regarding the re-login, did you encounter any new problems?

luke- commented 10 months ago

Just merged the PR and released 1.0.84

marc-farre commented 10 months ago

Hey @marc-farre, regarding the re-login, did you encounter any new problems?

I can still have the problem in 2 situations

1/

Should be solved with https://github.com/humhub/app/issues/145

2/ The problem still occurs when the FireBase Device is not registered.

Should be solved with https://github.com/humhub/fcm-push/issues/30

About push notifications redirects, looking into it.

Thanks, it works!

luke- commented 8 months ago

@marc-farre I'm closing it. Let me know when it's still open.