search

humhub / app

22 stars 8 forks source link

Prevent page refresh when swiping down #147

Closed marc-farre closed 11 months ago

marc-farre commented 11 months ago

I had a feedback about message lost before submitting, because the user wanted to scroll up the page, but when the page is already at the top, swiping down refreshes the page.

luke- commented 11 months ago

Hmm, should there a warning dialog? The page refresh is often helpful.

marc-farre commented 11 months ago

Yes, maybe with the "Unsaved changes will be lost. Do you want to proceed?"? https://github.com/humhub/humhub/blob/master/protected/humhub/widgets/CoreJsConfig.php#L50

@luke- should I move this issue on https://github.com/humhub/humhub/issues/?

luke- commented 11 months ago

@marc-farre Isn the dialog triggered on mobile devices?

marc-farre commented 11 months ago

No. Even on browser. This dialog is triggered on PJAX reloading I think, or something like that, but not with browser refreshing. Moreover, with the Messenger module, the dialog is nether triggered, event when clicking on a link such as a top menu entry or closing the modal box for a new conversation.

luke- commented 11 months ago

Ok, then I would say it's a bug in the core repo or mail module, when the dialog is never triggered there.

marc-farre commented 11 months ago