humhub / app

22 stars 8 forks source link

Workaround zoom into picture not available on app #184

Closed JK742020 closed 6 months ago

JK742020 commented 6 months ago

Because there is no possibility to just zoom into a picture by default we use a workaround with PWA and Browser which is

  1. touch picture a little longer
  2. in the context menu choose "open in Browser"

Using the android app there is no context menu appearing at all.

Solution

marc-farre commented 6 months ago

@JK742020 there is a pinch-to-zoom functionality which work on the Android mobile app and web browser.

marc-farre commented 6 months ago

Related to https://github.com/humhub/humhub/issues/5310

ArchBlood commented 6 months ago

I've tested in android 12 which does not work in the app @marc-farre.

marc-farre commented 6 months ago

Strange. Tested on Android 10, it works for me. I'll do more tests later.

JK742020 commented 6 months ago

Never worked with my mobile neither the versions before nor android 13 which is installed right now. This is the fact in the app and PWA of my network and also of the humhub-community.

marc-farre commented 6 months ago

@luke- I think this issue can be closed as it should be fixed by https://github.com/humhub/humhub/issues/5310#issuecomment-2121084157

@ArchBlood @JK742020 When I tested, I was with the Clean Theme module. So you're right, with the HumHub community module, you cannot zoom.

luke- commented 6 months ago

@marc-farre Ok, then have the Core PR tested first.

But I could think that we have somehow deactivated the zoom for the app as well.

marc-farre commented 6 months ago

@luke- I confirm zooming in works on this mobile app when maximum-scale=1.0, user-scalable=no is removed from https://github.com/humhub/humhub/blob/master/protected/humhub/views/layouts/main.php#L13 (tested).

luke- commented 6 months ago

@marc-farre Great, thank you for testing! Then I'll close this!