search

humhub / auth-linkedin

0 stars 2 forks source link

Test & Release #1

Closed luke- closed 1 year ago

serh-mosk commented 1 year ago

To check the operation of this module, I need Client ID and Client secret, which can be obtained only by creating an application in the https://developer.linkedin.com/ cabinet. Can you provide them to me or do I need to create a test LinkedIn account?

luke- commented 1 year ago

@yuriimaz Would be great if you can create a test linked in account

serh-mosk commented 1 year ago

I created a test configuration for the project on LinkedIn and checked the operation of the authorization module. Since a problem was detected with the registration of a new user in the event of an attempt to authorize using LinkedIn Auth, I made the appropriate changes in the registration class of the main project and created a pull-request with these changes https://github.com/humhub/humhub/pull/6244. Please check that everything is correct and let me know if anything needs to be corrected.

luke- commented 1 year ago

@yuriimaz Thanks, I have already replied to the PR in the main project. Please try to make the changes only in the AuthClient of the LinkedIn project.

serh-mosk commented 1 year ago

I've made changes to the module, but I can't create a branch and commit to it to prepare a pull request, because I don't have permission to do so. @luke- Can you check if editing rights are enabled for my account?

luke- commented 1 year ago

@yuriimaz Please try it again