humhub / calendar

Create one-time or recurring events, invite and manage attendees, and keep track of all your events with the Calendar module.
28 stars 46 forks source link

Invite Users / Manage Users #263

Closed luke- closed 2 years ago

luke- commented 2 years ago

image

Related to: https://github.com/humhub/calendar/issues/1

orangiene commented 2 years ago

@yurabakhtin okay, I see... then leave it as it is. Thanks

Semir1212 commented 2 years ago

A few changes to the wording @yurabakhtin

Overview

image

today --> Today month --> Month week --> Week day --> Day list --> List

Create Event

image

From top to bottom:

Create event --> Create Event Basic --> General

All day --> checkbox not checked per default Public (Also visible...) --> Public (Visible to all registered users, not only to Space members)

If event is in 'edit mode' include additional checkbox --> 'Send Update Notification' (from 'Participants' view); Rename it to ' Notify participants about changes'; Place checkbox on the level of close/save buttons.

Headline in 'edit mode' --> Edit Event instead of Edit event

Event Participants

image

Event Participants --> Participants New headline above first dropdown --> 'Mode'

Allow participation state... --> Allow option 'Decline' Allow participation state... --> Allow option 'Undecided'

Participation Info --> Additional Information for participants Send update notification --> Notify participants about changes

Stream Entry Options

image

Edit --> Edit Event (if possible) Edit Participants --> Participants

image

Add new participants --> Add participants... Invite all participants from the Space --> Invite all Space members Attend --> Attending Maybe --> Undecided 2 participants --> 2 Participants

Stream Entry

image

1 Attending 5 Undecided 12 Declined 28 Invited

Download as ICS file --> Donwload ICS

luke- commented 2 years ago

@yurabakhtin Can you please update the wording as Semir suggested.

yurabakhtin commented 2 years ago

@luke- I am working on this, but I have questions:

All day --> checkbox not checked per default

Currently the state of this checkbox is initialised depending on date/time. For example, if we switch to "week" or "day" calendar view and click to create a new event then the checkbox "All day" is unchecked because start and end times are provided. Also if we will click there("week" or "day" views) on the first row with name "all-day" then "All day" is checked automatically. Do we really should uncheck the checkbox "All day" even the time values are not provided? If yes, what we should put in the time fields, 12:00AM - 12:00PM?

Public (Also visible...) --> Public (Visible to all registered users, not only to Space members)

Please note the text is located inside the core widget \humhub\modules\ui\form\widgets\ContentVisibilitySelect - https://github.com/humhub/humhub/blob/master/protected/humhub/modules/ui/form/widgets/ContentVisibilitySelect.php#L78 . Should I modify the text right in the core widget? Or should I modify the core widget in order to allow define custom text from external module as new option of the widget?

yurabakhtin commented 2 years ago

@luke- Commit https://github.com/humhub/calendar/pull/264/commits/b76df96b064c3f6f3156246eb81b18bdaca49356 for new updates in wording except of 2 points above.

orangiene commented 2 years ago

Hi @yurabakhtin ,

can you please update the buttons an batch like in the screens: https://www.figma.com/file/tshvUVBzxy7uW8eZs6n6IG?node-id=0:1#156447864

Default: calendar-stream-01a

Selected: calendar-stream-01b

luke- commented 2 years ago

@yurabakhtin

yurabakhtin commented 2 years ago

@orangiene Commits https://github.com/humhub/calendar/pull/264/commits/35d520026c7f3d50779b38363afa3e67e52a4049, https://github.com/humhub/calendar/pull/264/commits/9f56fb18d3fc22620c4f3531fbb84b2af4bedf0b:

button_styles
orangiene commented 2 years ago

@yurabakhtin looks good, could you please just make the space between participants and buttons a bit bigger? 32px would be perfect, thank you.

yurabakhtin commented 2 years ago

@orangiene Commit https://github.com/humhub/calendar/pull/264/commits/587a2afefece24c76eb49a8ef3158a2a031b366d:

button_space

@luke-

  • All Day: If the user clicks on the "all day" section, ideally "all day" is still checked. For all other cases (e.g. click on day on Month view) show the next full hour and end time +1h. if start time is gt 23:00 show 10:00 -> 11:00 as fall back.

Ok, I will do this later. Do I understand you correctly: for example, if now is 10:05AM then on open form we should display start time - 11:00AM and end time - 12:00AM?

orangiene commented 2 years ago

looks good, thank you! :-)

yurabakhtin commented 2 years ago

@luke-

  • All Day: If the user clicks on the "all day" section, ideally "all day" is still checked. For all other cases (e.g. click on day on Month view) show the next full hour and end time +1h. if start time is gt 23:00 show 10:00 -> 11:00 as fall back.

Commit https://github.com/humhub/calendar/pull/264/commits/b874afa47418056ddade234c19caaab339201d8f, please check if it works as expected:

not_all_day
luke- commented 2 years ago

@yurabakhtin Yeah, works well. Can you just show instead of when it is currently 16:16 as Start Time 17:00 and End Time 18:00? (Instead of 16:00-17:00)

yurabakhtin commented 2 years ago

@luke-

Can you just show instead of when it is currently 16:16 as Start Time 17:00 and End Time 18:00? (Instead of 16:00-17:00)

Do you want to say that on your side you see times 16:00-17:00, when your current time is 16:16? If yes, then it seems I need to fix the result of the function date('H') depending on time zone.

luke- commented 2 years ago

Yes. It's now 16:59 and I see following defaults: image

Better defaults would be. Start: 17:00 End: 18:00

yurabakhtin commented 2 years ago

@luke- Ok, thanks for details, I will fix this.

yurabakhtin commented 2 years ago

@luke- I have retested again this with different timezone values in php server settings and in user settings and really cannot reproduce your issue:

test_time