search

humhub / calendar

Create one-time or recurring events, invite and manage attendees, and keep track of all your events with the Calendar module.
28 stars 46 forks source link

Fix tests #381

Closed yurabakhtin closed 1 year ago

yurabakhtin commented 1 year ago

Issue: https://github.com/humhub/humhub-internal/issues/191

luke- commented 1 year ago

@yurabakhtin Looks good for me. Ready for merge? Do you know whats the problem with develop?

yurabakhtin commented 1 year ago

@yurabakhtin Looks good for me. Ready for merge? Do you know whats the problem with develop?

@luke- No, it is not ready for merging, it is why I posted this PR as draft because I was not sure all tests will be executed without errors. Here I tried to fix the same error in the line 34. $I->seeInField("#calendarentry-participation_mode",0) at codeception/acceptance/SettingsCest.php:44 that appears after tests executig by cron job. Currently we have only this single error on the develop side, but it is strange because I cannot reproduce this on my local site and really the error cannot be depend on the core code, however on master side we don't have such error.

Maybe I will do some attempts to fix it on the develop github side, but from local side it looks correctly because the <select> element exists there as expected:

calendar_test_participants

yurabakhtin commented 1 year ago

@luke- Also if we look at the file codeception-output.zip:

SettingsCest testInstallAndCreatEntry github fail

and HTML code:

<div class="form-group field-calendarentry-participation_mode">
<label class="control-label" for="calendarentry-participation_mode">Mode</label>
<select id="calendarentry-participation_mode" class="form-control" name="CalendarEntry[participation_mode]" data-action-change="changeParticipationMode">
<option value="0" selected="">No participants</option>
<option value="1">Only by Invite</option>
<option value="2">Everybody can participate</option>
</select>
yurabakhtin commented 1 year ago

@luke- Solution for develop has beed done in the commit https://github.com/humhub/calendar/pull/381/commits/31bffe8c523f4f8dcec1521156cfbb136d4699fc. You can merge this PR.