Closed Semir1212 closed 1 year ago
the invitation function should be deactivated in this case. Inviting other users should only be possible if the event created is marked as public.
I personally disagree. I would love to use my private calendar to schedule events with other individuals - e.g. for 1-on-1 conversations that are out of scope of any of the spaces.
I agree though with the user experience being confusing. What if invites are possible and the result is that every participant gets access to this event, but not others on my calendar?
Currently, it seems to be possible to invite other users to events created on one's own profile. Since the events created are only visible to the user by default, the invitation function should be deactivated in this case. Inviting other users should only be possible if the event created is marked as public.
@Semir1212 I have investigated this and as I understand you want to disable the invitation function completely for any private event because it cannot be visible for example from notification like this:
Indeed it should be fixed, but I don't think we should disable the invitation function for all users because at least friend can view the Private event:
So I think we should fix to allow the invitation only for users which can read the event.
@Semir1212 @luke- PR https://github.com/humhub/calendar/pull/408 - I have fixed to allow invitation only for users who can view the Event:
If users cannot read the Event:
If at least one user cannot read the Event:
If all users can read the Event:
@Semir1212 What do you think? If you like this solution, can you please check the wordings?
I think it is confusing if you can select the users but then can’t invite.
Can’t they be disabled (greyed out) in the user picker?
That is how it is done in space events with non-members of the space. (And I think it would be good if the behavior here is the same.)
@felixhahnweilheim
I think it is confusing if you can select the users but then can’t invite.
I agree.
@luke- Should we improve this?
@yurabakhtin Yes, I also would prefer this. Then we also need such complex status messages.
I'm trying to understand the situation, so plz correct me if any of my statements are wrong
1) Private events in my accounts calendar are automatically visible to friends 2) Scheduling events from my private calendar is only possible if I befriend people first
@dantefromhell
I'm trying to understand the situation, so plz correct me if any of my statements are wrong
- Private events in my accounts calendar are automatically visible to friends
Yes, freinds can view any private content posted on your profile page. This rule is related for any other record posted on your profile wall stream, not only for calendar event.
Please note Friendship System must be enabled, it is in /admin/setting/basic
: Administration -> Settings -> General -> Friendship -> [x] Enable user friendship system.
Also if the config adminCanViewAllContent
is enabled for module "Content" https://docs.humhub.org/docs/admin/config-options/#content then all admins and users with permission "Manage Users (Can manage users and user profiles.)" can view the private records too.
- Scheduling events from my private calendar is only possible if I befriend people first
Sorry not clear, do you mean: can I create a private calendar event on my profile page if no friends yet?
answer: yes, you can create a private calendar event, but you can invite to the event only users who can view it, so as you understand from above text, they may be either friends or admins or user managers with enabled moduel config content.adminCanViewAllContent
. If no such users in system then only you will see the private event.
I think it is confusing if you can select the users but then can’t invite.
Yes, I also would prefer this. Then we also need such complex status messages.
@luke- Commit https://github.com/humhub/calendar/pull/408/commits/b934c4533fc72918407fdab1d9df5a03dfed4547. Yes, we don't need anymore the new status messages "Skipped: A, C" and "Invited: B, D. Skipped: A, C". I removed them, keep only previous "Invited: B, D".
freinds can view any private content posted on your profile page. This rule is related for any other record posted on your profile wall stream, not only for calendar event.
May I say how confusing this is? So "private" does not mean "private - for my eyes only", but more "private - with exceptions".
If it behaves differently than private, it should IMO be labelled differently for intuitive understanding. And with the introduction of a new label (e.g. "friends-only") I suspect the UI can become more intuitive, e.g.
Sorry not clear, do you mean:
Apologies for the inprecise question. I intended to ask if it's now a requirement to befriend another user first, before being able to invite them to a private event. Which I read from your answer is a "yes".
Will the UI reflects this rather complex rule-set? It should IMO include hints during the invite process that educate the user around the limitations. Especially the private event + befriending requirement.
@dantefromhell
May I say how confusing this is? So "private" does not mean "private - for my eyes only", but more "private - with exceptions".
Maybe yes the word "private" confuses, but I don't find this word in UI:
please not for Space calendar event we have a bit different text:
If it behaves differently than private, it should IMO be labelled differently for intuitive understanding. And with the introduction of a new label (e.g. "friends-only") I suspect the UI can become more intuitive, e.g.
- No invite button for a real private event
- Only people one is befriend with show up in the invite dialog for a 'friends-only' event
- Being able to invite everybody on a public event
@Semir1212 @luke- Do you think it should be improved somehow? But please note the checkbox text and tooltip text is from core, i.e. it is applied for all Content Records, not only for the Calendar Entry.
Apologies for the inprecise question. I intended to ask if it's now a requirement to befriend another user first, before being able to invite them to a private event. Which I read from your answer is a "yes".
Yes, you understood this correctly.
Will the UI reflects this rather complex rule-set? It should IMO include hints during the invite process that educate the user around the limitations. Especially the private event + befriending requirement.
Please review my comment https://github.com/humhub/calendar/issues/391#issuecomment-1672861999 again, I have added there a screenshot recently with new text "This user cannot view the private calendar entry". Probably we should modify the text to add some info about friendship will gives a possibility to invite user. @Semir1212 Could you please help to make this new string more correct? Thanks.
@yurabakhtin "Private events are only visible to you and, if the friendship system is activated, to your friends."
"Private events are only visible to you and, if the friendship system is activated, to your friends."
@Semir1212 Commit https://github.com/humhub/calendar/pull/408/commits/c0f097804aa009bdc5daf888ba31f3b4f83b6fe2:
Currently, it seems to be possible to invite other users to events created on one's own profile. Since the events created are only visible to the user by default, the invitation function should be deactivated in this case. Inviting other users should only be possible if the event created is marked as public.