humhub / calendar

Create one-time or recurring events, invite and manage attendees, and keep track of all your events with the Calendar module.
28 stars 46 forks source link

Global calendar header redesign #447

Closed marc-farre closed 7 months ago

marc-farre commented 7 months ago

The actual header of the global calendar is quite different from the other global pages such as the People and Space pages.

marc-farre commented 7 months ago

@luke- https://github.com/humhub/calendar/pull/448

I tries to make the code more conventional.

I had to change 2 translations (to remove the <strong> HTML elements):

Before: image

After: image

dantefromhell commented 7 months ago

I personally prefer the bold text, it gives visual clues to where I can take action on the page.

marc-farre commented 7 months ago

I personally prefer the bold text, it gives visual clues to where I can take action on the page.

So in this case we should have bold also on the People page: image

But the more bold you add, the more confusion on the page you get. Bold should be on few elements we want to focus on. This is a filter, so it should not be too proeminent.

And what I removed is the <bold> tag for the first word of the text, but even in the old version it was all bold with CSS, so this tag is useless anyway. And you can always add bold with the theme.

marc-farre commented 7 months ago

We have the same page style on the Spaces page: image

The title of the page (which was missing) and small filter labels.

dantefromhell commented 7 months ago

Bold should be on few elements we want to focus on. This is a filter, so it should not be too proeminent. I very much agree.