search

humhub / calendar

Create one-time or recurring events, invite and manage attendees, and keep track of all your events with the Calendar module.
28 stars 46 forks source link

Upcoming events widget not shown if no upcoming events #455

Open dantefromhell opened 6 months ago

dantefromhell commented 6 months ago

This behaviour had me confused for quite a bit, maybe it is intentional.

When the Upcoming events widget is enabled but the calendar has no entries, the whole widget won't be displayed. When doing space configuration this can be very confusing, as Space Owners might think the function is disabled.

IMO a better solution would be to display the Upcoming events widget with a small No events yet string.

I'm happy to try my hand on a PR, some guidance might be required though.

dantefromhell commented 6 months ago

This turned out to be quicker than expected.

I've created a draft PR because the approach has not been discussed/ approved by upstream. Please advise if this solution is in line with HumHubs standards.

luke- commented 6 months ago

Thanks for the Draft PR.

Hmm, a configuration option could be useful here. Currently the Space Admin can't control whether the widget is displayed, or not?

dantefromhell commented 6 months ago

Currently the Space Admin can't control whether the widget is displayed, or not?

That's my understanding, yes. I do agree on the configuration option to be a good addition too.

Would that be part of this issue/ PR or a new issue/PR?

luke- commented 6 months ago

You are welcome to integrate it into your current PR.