humhub / calendar

Create one-time or recurring events, invite and manage attendees, and keep track of all your events with the Calendar module.
28 stars 46 forks source link

Canceled Events: add CSS class #457

Closed felixhahnweilheim closed 6 months ago

felixhahnweilheim commented 6 months ago

This PR adds a CSS class 'canceled' to canceled events. This way themes can manipulate the background color of the event or strike through the title.

Related: https://github.com/humhub/calendar/issues/320

Please let me know if I also should add CSS to strike through the title.

felixhahnweilheim commented 6 months ago

This CSS would work for month, week, day and list view and only strike through the event title, not the time.

.fc-view .canceled .fc-title, .fc-view .canceled .fc-list-item-title {
  text-decoration: line-through;
}
luke- commented 6 months ago

@felixhahnweilheim Thanks for the PR.

Can you please add a screenshot with the strikethrou? Then we can discuss whether to add it.

felixhahnweilheim commented 6 months ago

Screenshot 2024-02-17 at 12-15-19 Calendar - Felix Hahn Development Screenshot 2024-02-17 at 12-15-41 Calendar - Felix Hahn Development Screenshot 2024-02-17 at 12-15-31 Calendar - Felix Hahn Development

luke- commented 6 months ago

@Eladnarlea What do you think?

Eladnarlea commented 6 months ago

@luke- I like the idea and think it is useful information. Do we need the extra (canceled) info even if the title has already been struck through?

@felixhahnweilheim do you suggest to leave the time as it is, or is it not possible to strike it through as well?

this is how it looks in apple calendar.

Screenshot 2024-02-19 at 10 53 16 AM
felixhahnweilheim commented 6 months ago

I have updated the PR to the following:

Screenshot 2024-02-19 at 19-06-29 Calendar - Felix Hahn Development Screenshot 2024-02-19 at 19-03-07 Calendar - Felix Hahn Development Screenshot 2024-02-19 at 19-13-20 Calendar - Felix Hahn Development

luke- commented 6 months ago

@felixhahnweilheim @Eladnarlea Thank you!