Export button missing when viewing Space calendar

humhub / calendar

Create one-time or recurring events, invite and manage attendees, and keep track of all your events with the Calendar module.

28 stars 46 forks source link

Export button missing when viewing Space calendar #478

Closed dantefromhell closed 3 months ago

dantefromhell commented 3 months ago

The calendar header when viewed from a Space is missing the "Export" button.

In the global calendar view the export button is still available

The export button used to be available when viewing a Space calendar in the past, I'm not certain which version upgrade or commit changed the behaviour.

Calendar module version: 1.5.10 HumHub version 1.15.5

luke- commented 3 months ago

@yurabakhtin Any idea?

felixhahnweilheim commented 3 months ago

In https://github.com/humhub/calendar/pull/448 CalenderControls was removed from the filterbar view file and moved to the global view only. I think the idea was to remove the cog symbol from the spaces view and only show in the global view (to reduce confusion).

So I think this should be reverted and the CalendarControls has to differentiate between global and container view.

yurabakhtin commented 3 months ago

@luke- PR https://github.com/humhub/calendar/pull/480:

luke- commented 3 months ago

@yurabakhtin Did we remove that on purpose or was it a bug?

yurabakhtin commented 3 months ago

@luke- I think the controls were removed from the space calendar header by mistake here https://github.com/humhub/calendar/issues/447.