search

humhub / cfiles

Module for managing files inside spaces and user profiles.
17 stars 19 forks source link

Text Editor in file Edit - Image insert doen't work properly #226

Open Gilbertdelyon opened 2 weeks ago

Gilbertdelyon commented 2 weeks ago

HHv1.55 - Files Version 0.16.6 Steps to reproduce:

  1. Open a space
  2. Clic "Files" in right menu
  3. Right clic on a file
  4. Select "Edit". A modal is displayed. You can edit the post.
  5. In editor's menu click "upload file".
  6. Upload an image.
  7. The image is displayed in editor.
  8. So far So good.

And now the issue: You cannot modify the image size

Go back to the stream Open the post Same issue - You cannot modify the image size

Gilbertdelyon commented 2 weeks ago

Addition: Different behavoiur in HH1.15 and HH1.16 (File Version 0.16.6 in both)

  1. In HHv1.15 you get this: image

  2. In HHv1.16 you get only this image

luke- commented 2 weeks ago

Does this only affect images in the CFiles module RichText Editor?

e.g. Wiki, Polls, Profile About, are not affected?

Gilbertdelyon commented 2 weeks ago

As far as I can see HH1.15

  1. Polls: it works
  2. Wiki: itworks
  3. Profile/About: No Richtex editor (only textarea)

HH1.16

  1. Polls: it works
  2. Wiki: it works 50% (You can resize images but there is only one item ("load file") in dropdown menu) image
  3. Profile/About: No Richtex editor (only textarea)
luke- commented 2 weeks ago

Actually, there should be no difference here.

@yurabakhtin Can you take a look?

yurabakhtin commented 2 weeks ago

@luke- PR https://github.com/humhub/humhub-prosemirror/pull/146 - fix visibility of the edit image button, it was hidden because its z-index was less modal window z-index.

Actually, there should be no difference here.

New options for the upload menu were implemented here for v1.16.

The additional options go from the upload button if it exists on a form:

upload-options

but some forms have no the upload button so we have there only single "Upload File":

no-options

Should we find a solution for such case?

Gilbertdelyon commented 2 weeks ago

Hello, May I also remind you the initial post of this issue: (cannot modify image size in editor) I dont know if it's connected to the upload button issue. May be I should have post 2 different issues. Sorry.

yurabakhtin commented 2 weeks ago

May I also remind you the initial post of this issue: (cannot modify image size in editor)

@Gilbertdelyon Hello, as I wrote in the comment above, the bug has been fixed in the PR https://github.com/humhub/humhub-prosemirror/pull/146, and it will be in next release.

I dont know if it's connected to the upload button issue. May be I should have post 2 different issues. Sorry.

No, it is not related. The options "Image" and "Horizontal rule" were deleted from the version 1.16.