Closed yurabakhtin closed 1 year ago
@luke- Can you explain what exactly had to be entered before so that a similar title with an anchor appeared?
@yurabakhtin Can you please help here?
@yuriimaz
master
v1.14.3, you should find an anchor on over mouse,develop
v1.15.0 (don't forget to run composer install
from root), you see the anchors are lost for the headers,@luke- @yurabakhtin I still don't understand. What exactly should be entered in the editor so that after saving we get the expected look of the title with an anchor?
@yurabakhtin Is just the text enough to make the header?
@luke- @yurabakhtin I still don't understand. What exactly should be entered in the editor so that after saving we get the expected look of the title with an anchor?
Try to create some "headline 1" elements.
@yuriimaz
I still don't understand. What exactly should be entered in the editor so that after saving we get the expected look of the title with an anchor?
Just try to create a Wiki page with some random text then apply "Heading 1" or "Heading 2" to the text, so an expected result is that text should be rendered as <h1 id="header-text">Header text<a href="#header-text">...</a></h1>
but wrong result is <h1>Header text</h1>
, please find more details on my screenshots and in the investigation above, or please ask me more details if you cannot reproduce the bug on the develop v1.15.0
(don't forget to refresh by composer install
when you switch between branches master
and develop
).
@yurabakhtin @luke- Thanks. I can already see it, I'm trying to fix it.
Problem from here https://github.com/humhub/wiki-2.0-issues/issues/49#issuecomment-1630820696:
markdown-it-anchor
was updated from version6.0.1
to8.6.7
permalink: true
should be updated to something like thispermalink: markdown_it_anchor_plugin.permalink.headerLink()
How it is broken now:
Expected result on render header: