When registering, links to privacy policy, terms of use lead away from registering process

Eladnarlea commented 1 month ago

What steps will reproduce the problem?

Register for a HumHub Network -> fill in personal information -> one of the last steps is to read through the privacy policy and terms of use -> click back to get back to the register form ---> no getting back

What is the expected result?

when I fill in a form that asks me to agree to something, I expect to be led back to the form after reading through the extended information

What do you get instead?

I will be led back to the starting page of the network and have to fill in the form again

Additional info

https://github.com/user-attachments/assets/5ef3cf12-44fb-413b-824d-aa4bc74d84c6

luke- commented 1 month ago

The simplest solution would probably be to open it in a new tab.

marc-farre commented 1 month ago

The simplest solution would probably be to open it in a new tab.

Or a modal box?

luke- commented 1 month ago

It would be better, but more complicated, unfortunately. We need a different rendering of the custom pages for that.

ArchBlood commented 1 month ago

In this case I'd suggest a new tab over modal, as the text can be rather long in this use case.

Another alternative would be replacing the go back button with an actual button that goes back to the previous loaded page.

yurabakhtin commented 1 month ago

The simplest solution would probably be to open it in a new tab.

@luke- The links already have this feature, we can check target="_blank" here and here

But the button "Go back" always has an url to / - https://github.com/humhub/legal/blob/master/views/page/layout_login.php#L26. To improve it we could use here Yii::$app->request->referrer instead of the ['/']. If we will do this then it will works like this:

User opens a first tab, and enters some data there
then second tab is opened with "Privacy Policy"
on click "Go back" the user will sees the registration form in the second tab and the form is empty, so user should either fill it again or switch manually to the first tab to continue the registration process.

If we need a real "go back" action then we could remove the target="_blank" from the legal links and assign js action window.history.back() for the "Go back" button. In such case all entered data will be stored so user can continue it after the js "go back" action. However this js back action doesn't work correctly after we see the page after user login action, so probably it is better for now is to keep the target="_blank" and change url from ['/'] to Yii::$app->request->referrer.

luke- commented 1 month ago

Ok, I see. So the links already open in a new window/tab, but of course the user is then not longer in the registration process. (Need so switch tabs).

From the UI, this sounds like that we really need modals here. I think we should create an issue in the Legal module for this. "Use Modals ..."

humhub / legal