search

humhub / mail

A private messaging system for direct communication.
https://marketplace.humhub.com/module/mail
29 stars 50 forks source link

Add "Send message" to People cards #257

Open marc-farre opened 2 years ago

marc-farre commented 2 years ago

What do you think about adding a "Send message" button to the cards in the People page? image

If you agree with this idea, I can send a PR adding an event to add an item on PeopleActionButtons widget.

luke- commented 2 years ago

@orangiene Can you please take a look here? Do we have a concept regarding the button colors/types for cards?

orangiene commented 2 years ago

I like the idea, let's do it. Button colors unfortunately do not follow a uniform logic at the moment. It is especially important that the user can "Follow" - that would be primary color for me. While sending a message has rather smaller prio, therefore secondary color.

marc-farre commented 2 years ago

Thanks @orangiene . As the buttons' type list is https://github.com/humhub/humhub/blob/master/protected/humhub/widgets/BootstrapComponent.php#L47, can I use default for secondary color? On Humhub community theme, the default color is #f3f3f3, which is quite close to the secondary color which is #7a7a7a.

marc-farre commented 2 years ago

@luke- https://github.com/humhub/mail/pull/258 but because of this problem: https://github.com/humhub/humhub/issues/5622 See my comment on the PR.

marc-farre commented 11 months ago

@luke- We have an unresolved discussion here: https://github.com/humhub/mail/pull/258#issuecomment-1087442697 The problem was to determine the number of buttons. Once we've decided, I'll create a new PR on the current develop branch. Thanks!

Eladnarlea commented 11 months ago

@luke- @marc-farre I think it's a great opportunity to use an icon button that could turn into a floating button in the future. What do you think about it?

Screenshot 2023-12-12 at 11 18 41 AM
marc-farre commented 11 months ago

@Eladnarlea Thanks! Yes, I think it's a very good idea. @luke- Should I create a PR for this?

luke- commented 11 months ago

What about a menu like this? image

Eladnarlea commented 11 months ago

@luke- a menu like this is less intuitive than the icon button. Also for mobile it is less practical.

luke- commented 11 months ago

@Eladnarlea I see your point, but for me the people cards are a bit bloated.

image

If we had a "hidden" decent menu, we could also put other additional not that important options (Block, Edit as Admin, ...) in there.

Maybe we could also: image

Or without a new menu: We could always display the mail symbol at the bottom (and either +Friends or +Follow - depending on the HumHub configuration. It's confusing for many users anyway, the difference between follow/friends)

For me, however, the solution with the "message" button at the top would also be fine. Even if it's not my favorite.

Eladnarlea commented 11 months ago

If we had a "hidden" decent menu, we could also put other additional not that important options (Block, Edit as Admin, ...) in there.

I would advise against applying too many options to each page of the software. We should first define what the "people cards" are for and what you can do on the page. Blocking, for example, is a fairly specific action that is rarely used in mass processing. So I don't think it's necessarily relevant to the People Cards page.

Or without a new menu: We could always display the mail symbol at the bottom (and either +Friends or +Follow - depending on the HumHub configuration. It's confusing for many users anyway, the difference between follow/friends)

I like this, I think it's also confusing and we should offer either/or. "Follow" is also an action that should be configured when on the specific profile.

For me, however, the solution with the "message" button at the top would also be fine. Even if it's not my favorite.

@luke- let me think of another way to deal with the "bloated" cards, I would like to provide a different approach.