search

humhub / polls

Empower your users to create polls and survey to drive engagement and gather valuable insights from your community.
15 stars 24 forks source link

PHP Version #106

Closed TheFox closed 1 year ago

TheFox commented 1 year ago

What is the minimum required PHP version for this module? I saw some of the code is probably PHP 7, but I am not sure. Are there any plans for migrating it to PHP 7 and further to PHP 8?

For example the old array syntax using array() is used instead of the new [].

Also the fully qualified class name is used as a string instead of ::class.

luke- commented 1 year ago

We test it against 7.4

TheFox commented 1 year ago

How can I know? How do you know? There is no composer.json or something.

luke- commented 1 year ago

You can see here with which HumHub version the module is compatible. https://github.com/humhub/polls/blob/master/module.json#L8

The requirements for the modules are the same as for the respective HumHub version.

TheFox commented 1 year ago

@luke- But the website https://docs.humhub.org/docs/admin/requirements#php-environment says we can you PHP 8.1 ? So what's right here?

Why are some of the Yes in bold and some not?

luke- commented 1 year ago

@TheFox Yes, the latest version should work with PHP 8.1 to 7.4. If there is a problem here, feel free to open a bug report.

Bold are recommended versions.

TheFox commented 1 year ago

But you wrote

We test it against 7.4

So you also testing against 8.0 and 8.1 ?

luke- commented 1 year ago

@TheFox Ah sorry, I meant the minimum version we are testing is 7.4. Currently 7.4, 8.0 and 8.1 should be tested automatically.

See here: https://github.com/humhub/polls/actions/runs/3387741168