humhub / polls

Empower your users to create polls and survey to drive engagement and gather valuable insights from your community.
16 stars 24 forks source link

Mandatory Description #107

Closed Semir1212 closed 2 years ago

Semir1212 commented 2 years ago

Currently adding a description is required to create a poll, that should not be the case. Additionally, there is currently no error message indicating this.

If the description is supposed to stay mandatory, at least an error message should be added.

yurabakhtin commented 2 years ago

@luke- I see the error message "Description cannot be blank." when submit an empty form:

poll_empty

If I remember correctly there is no field "Question" in old version, we had only "Description", then we added the "Question" field and kept the old field "Description" mandatory as it was before.

So please confirm if we really need to make the field "Question" as mandatory instead of the field "Descripiton", thanks.

Semir1212 commented 2 years ago

@yurabakhtin In my test environment these error messages do not appear, but I can remember that they used to exist, now that I see your screenshot.

The description being mandatory and the question itself being not makes even less sense. I would reverse this behaviour. @luke-

luke- commented 2 years ago

@Semir1212 The problem here is, the "Question" field is newly added. I.e. there is already content without this field filled in.

But for new polls I would definitely make Question mandatory and Description optional.

yurabakhtin commented 2 years ago

@luke-

But for new polls I would definitely make Question mandatory and Description optional.

Do you mean for new version we should make Question mandatory and Description optional? Or do you mean to detect someshow what poll is old and what poll is new and make it only for new polls? However I am not sure how it is possible to find what poll is old, so we can do this for all polls, do you agree this change?

luke- commented 2 years ago
yurabakhtin commented 2 years ago

@luke- PR https://github.com/humhub/polls/pull/108.