search

humhub / polls

Empower your users to create polls and survey to drive engagement and gather valuable insights from your community.
15 stars 24 forks source link

Fix tests #98

Closed yurabakhtin closed 2 years ago

yurabakhtin commented 2 years ago

Issue: https://github.com/humhub/team_tasks/issues/229

luke- commented 2 years ago

@yurabakhtin Can you please increase the min HumHub Version and the Changelog?

luke- commented 2 years ago

image When try to access poll module on latest develop version

yurabakhtin commented 2 years ago

@luke-

When try to access poll module on latest develop version

I wrote here https://github.com/humhub/team_tasks/issues/229#issuecomment-1161268687 the branch develop has new declaration of the method WallCreateContentForm::renderForm(ActiveForm $form): string. This PR fixes the error, but I suggested to revert the change in the method and create a new method with name like renderActiveForm. So this new method renderActiveForm will be used in core develop branch and we don't need this module fix PR at all.

luke- commented 2 years ago

@yurabakhtin Ok, understood. Then let's refactor the develop branch change!

yurabakhtin commented 2 years ago

@luke-

Then let's refactor the develop branch change!

PR https://github.com/humhub/humhub/pull/5765.